feat(files): allow hidding files extensions #53966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
artonge,
sorbaugh and
susnux
and removed request for
a team
susnux
approved these changes
Jul 16, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
In general it makes sense - similar to 🪟 is doing it (which I do not like but I understand we want to also please those users ;) ).
But would like to have feedback of @nickvergessen because it might be exploited to show users files like image.jpg.exe as just image.jpg.
Though the user itself has to disable fileextensions explicitly.
skjnldsv
force-pushed
the
feat/show-hide-ext
branch
from
33ed695 to
81b537b
Compare
Member
|
Yeah as @susnux said, I don't like it, people are tripping and falling for it, but their operating system does it as well already, so … |
Member
Author
|
Also, it's opt-in 🤷 |
Contributor
We should just remember to never allow setting this for public shares (not possible yet, so currently not a problem). |
provokateurin
approved these changes
Jul 22, 2025
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
feat/show-hide-ext
branch
from
81b537b to
c7dd6dd
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additionally
Split the settings into two for cleaner UI
Checklist