-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(UnifiedSearch): Online search providers support, toggle option #53996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the naming should be external to make clear that this is about external services.
3937153 to
813a911
Compare
|
I agree with @susnux, other than that this LGTM. |
a35b261 to
aa34599
Compare
3c3bcf2 to
c2018bc
Compare
c2018bc to
0723427
Compare
Signed-off-by: Andrey Borysenko <[email protected]>
0723427 to
5c4e84f
Compare
|
I expected that results from external sources would be hidden or removed when the toggle is turned off again. Please clarify if that's intentional ;) Screencast.From.2025-08-14.20-57-25.webm(I've patched the CommentsSearchProvider to be an external provider locally.) |
The goal was to prevent search to external sources when not needed, I didn't think about removing existing search results on toggle, do you think this is necessary? |
I've just noticed it while testing. Whether it is wanted or not is more a question for product/design ;) I'm fine with the current version. |
Summary
This PR introduces new OCP
\OCP\Search\IExternalProviderinterface for Search providers with one methodisExternalProviderthat should return boolean to indicate whether this provider uses external (3rd-party) resources for search and forwards user query to it.Switch toggle added to UnifiedSearch modal to allow search using external providers (disabled by default).
Checklist