Skip to content

Conversation

@andrey18106
Copy link
Contributor

@andrey18106 andrey18106 commented Jul 17, 2025

Summary

This PR introduces new OCP \OCP\Search\IExternalProvider interface for Search providers with one method isExternalProvider that should return boolean to indicate whether this provider uses external (3rd-party) resources for search and forwards user query to it.
Switch toggle added to UnifiedSearch modal to allow search using external providers (disabled by default).

1

Checklist

@andrey18106 andrey18106 requested a review from a team as a code owner July 17, 2025 17:02
@andrey18106 andrey18106 requested a review from a team as a code owner July 17, 2025 17:02
@andrey18106 andrey18106 added the 3. to review Waiting for reviews label Jul 17, 2025
@andrey18106 andrey18106 removed the request for review from a team July 17, 2025 17:02
@andrey18106 andrey18106 requested review from nfebe, skjnldsv, susnux and yemkareems and removed request for a team July 17, 2025 17:02
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the naming should be external to make clear that this is about external services.

@andrey18106 andrey18106 force-pushed the feat/unified_search/online_providers branch from 3937153 to 813a911 Compare July 30, 2025 21:23
@provokateurin
Copy link
Member

I agree with @susnux, other than that this LGTM.

@andrey18106 andrey18106 force-pushed the feat/unified_search/online_providers branch 2 times, most recently from a35b261 to aa34599 Compare July 31, 2025 15:38
@nextcloud-command nextcloud-command requested a review from a team as a code owner July 31, 2025 15:47
@andrey18106 andrey18106 force-pushed the feat/unified_search/online_providers branch from 3c3bcf2 to c2018bc Compare July 31, 2025 20:02
@andrey18106 andrey18106 force-pushed the feat/unified_search/online_providers branch from c2018bc to 0723427 Compare August 13, 2025 18:29
@andrey18106 andrey18106 force-pushed the feat/unified_search/online_providers branch from 0723427 to 5c4e84f Compare August 14, 2025 13:38
@kesselb
Copy link
Contributor

kesselb commented Aug 14, 2025

I expected that results from external sources would be hidden or removed when the toggle is turned off again. Please clarify if that's intentional ;)

Screencast.From.2025-08-14.20-57-25.webm

(I've patched the CommentsSearchProvider to be an external provider locally.)

@kesselb kesselb merged commit 92e282a into master Aug 14, 2025
210 of 215 checks passed
@kesselb kesselb deleted the feat/unified_search/online_providers branch August 14, 2025 19:08
@andrey18106
Copy link
Contributor Author

I expected that results from external sources would be hidden or removed when the toggle is turned off again. Please clarify if that's intentional ;)
Screencast.From.2025-08-14.20-57-25.webm

(I've patched the CommentsSearchProvider to be an external provider locally.)

The goal was to prevent search to external sources when not needed, I didn't think about removing existing search results on toggle, do you think this is necessary?

@kesselb
Copy link
Contributor

kesselb commented Aug 14, 2025

do you think this is necessary?

I've just noticed it while testing. Whether it is wanted or not is more a question for product/design ;) I'm fine with the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to optionally disable available SearchProviders and/or set custom prefix-trigger

6 participants