chore: move smb package to 3rdparty #54012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
requested review from
artonge and
sorbaugh
and removed request for
a team
nickvergessen
approved these changes
Jul 20, 2025
nickvergessen
requested review from
come-nc
and removed request for
a team,
artonge and
sorbaugh
susnux
approved these changes
Jul 22, 2025
come-nc
approved these changes
Jul 28, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
What about autotest-external.sh 🥷
- Automated updates - Easier maintenance - Not having another copy of the streams packages Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
chore/move-smb-package
branch
from
470ed15 to
28dc3e2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For nextcloud/3rdparty#2103
For years, I’ve been wondering about the 3rdparty folder in files_external but was always too reluctant to touch it.
However, not having it in the original 3rdparty means we are not getting automated updates, and also leads to about having one copy of streams in 3rdparty and another one in apps/files_external/3rdparty. At the time of writing, they are once again in different versions (v0.7.8 vs. v0.7.7). While we could probably fix that by updating the definition for the stream-dummy package, I assume it’s easier to just move it around.
The CI will hopefully tell us if that’s a good idea or just terrible.
Checklist