fix: add unique index for users' mountpoints #54015
Closed
+46
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salvatore Martire <[email protected]>
salmart-dev
force-pushed
the
fix/addUniqueMountpointIndex
branch
from
8fc443d to
d659e15
Compare
Signed-off-by: Salvatore Martire <[email protected]>
Contributor
Author
|
NVM, adding a unique index is not possible because we would exceed the index size as the mount_point could be very long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #32877 the unique index was dropped to allow users to have multiple entries for the same mount, but different mountpoints. This leads to rows being duplicated and causes performance issues if the amount of duplication and users are not negligible.
Checklist