feat(files): hide note about app passwords when 2FA not enabled #54020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
requested review from
nfebe,
susnux and
yemkareems
and removed request for
a team
susnux
approved these changes
Jul 21, 2025
skjnldsv
approved these changes
Jul 22, 2025
skjnldsv
force-pushed
the
feat/42647/hide-app-password-note-without-2fa
branch
from
1e26ea2 to
4e955f6
Compare
Member
|
Ah it's already compiled lol. Not used to it |
kesselb
added
2. developing
Contributor
Author
|
Sorry, forgot to adjust the tests 🙈 |
kesselb
force-pushed
the
feat/42647/hide-app-password-note-without-2fa
branch
from
62f67f8 to
c4c6fc6
Compare
kesselb
added
3. to review
kesselb
force-pushed
the
feat/42647/hide-app-password-note-without-2fa
branch
from
c4c6fc6 to
f84860f
Compare
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]> Co-authored-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
feat/42647/hide-app-password-note-without-2fa
branch
from
f84860f to
cb29b30
Compare
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #42647
Close: #44594
Summary
Hide the note about app passwords when 2fa is not enabled.
This was initially implemented by @JED-B. I don't have a strong opinion on the related issue; I see no harm in always showing the 2FA hint, as it might even increase usage of it if people know that WebDAV still works with it enabled. However, it seems also okay to just hide it. I only brought the PR into a reviewable/mergeable state.
Before
After
Checklist