Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 21, 2025

Summary

An application requires group ids that contain slashes and colons. Full reasoning given:

Cloud Ids consist of username and remote parts. Usernames can also be group names. Federated groups are required to have "prefixes" to distinguish them from regular groups. Here group ids (gids) are written as Uniform Resource Names (URNs) that have colons and slashes as part of the uri scheme. We need to allow these characters as part of group names. Keep in mind that groups in Nextcloud can already contain these characters anyway.

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Jul 21, 2025
@susnux susnux marked this pull request as ready for review July 21, 2025 13:53
@susnux susnux requested review from a team and nickvergessen as code owners July 21, 2025 13:53
@susnux susnux requested review from ArtificialOwl, artonge and sorbaugh and removed request for a team July 21, 2025 13:53
@susnux susnux changed the title Enh/add cloud id chars feat: add ICloudIdResolver Jul 22, 2025
@susnux susnux force-pushed the enh/add-cloud-id-chars branch from b20447f to 75a66b5 Compare July 22, 2025 12:38
@smesterheide
Copy link
Contributor

Hi @susnux, thanks for applying the changes and finalizing the PR. Is there anything else for me to do?

smesterheide and others added 2 commits July 23, 2025 15:59
Co-authored-by: Dirk Olbertz <[email protected]>
Signed-off-by: Sandro Mesterheide <[email protected]>
@susnux susnux force-pushed the enh/add-cloud-id-chars branch from 75a66b5 to 66eb021 Compare July 23, 2025 13:59
@susnux susnux requested review from come-nc, nickvergessen and provokateurin and removed request for artonge July 23, 2025 13:59
@provokateurin provokateurin enabled auto-merge July 28, 2025 09:37
@sorbaugh sorbaugh disabled auto-merge July 28, 2025 13:49
@sorbaugh sorbaugh merged commit 4eda352 into master Jul 28, 2025
213 of 219 checks passed
@sorbaugh sorbaugh deleted the enh/add-cloud-id-chars branch July 28, 2025 13:49
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants