Skip to content

Conversation

@theking2
Copy link
Contributor

@theking2 theking2 commented Jul 22, 2025

Summary

In PHP single quote string \ need to be escaped.

Checklist

@theking2 theking2 requested a review from a team as a code owner July 22, 2025 06:11
@theking2 theking2 requested review from come-nc, icewind1991 and nfebe and removed request for a team July 22, 2025 06:11
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@DaphneMuller
Copy link

@nfebe could you give this a review please so it can be merged?

Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@nfebe
Copy link
Contributor

nfebe commented Aug 8, 2025

@theking2 I updated the branch for you with rebase, please fix the commit using conventional commits

I can't push to your branch, so you have to fix it yourself so this can be merged. Thank you.

@theking2 theking2 changed the title update memcache settings Fix: use double / in strings Aug 10, 2025
@skjnldsv
Copy link
Member

I can't push to your branch, so you have to fix it yourself so this can be merged. Thank you.

done

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Copy link
Member

/backport to stable31

@skjnldsv
Copy link
Member

/backport to stable30

@skjnldsv skjnldsv added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 12, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Aug 12, 2025
@DaphneMuller
Copy link

@skjnldsv @nfebe can this be merged?

@skjnldsv skjnldsv disabled auto-merge August 18, 2025 09:23
@skjnldsv skjnldsv merged commit 2d659b2 into nextcloud:master Aug 18, 2025
114 of 118 checks passed
@welcome
Copy link

welcome bot commented Aug 18, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants