-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(files_external): ignore unsatisfied optional dependencies #54048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7e371fc to
3d6f8b0
Compare
Signed-off-by: Jan-Philipp Litza <[email protected]>
3d6f8b0 to
de238bf
Compare
|
I simply cannot understand how my changes would affect the failing tests ("files_sharing: Note to recipient -> shows an existing note when editing a share" timeout), but re-running the failing jobs twice did not fix them… |
|
@jplitza ignore it, it's very unstable at the moment :) |
|
/backport to stable31 |
|
/backport to stable30 |
come-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine I think but I’d like @icewind1991 to check the logic.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Fix setup of external storage with unsatisfied optional dependencies (which were introduced in #52681)
Checklist