Skip to content

Conversation

@jplitza
Copy link
Contributor

@jplitza jplitza commented Jul 22, 2025

Summary

Fix setup of external storage with unsatisfied optional dependencies (which were introduced in #52681)

Checklist

@jplitza jplitza requested a review from a team as a code owner July 22, 2025 15:00
@jplitza jplitza requested review from come-nc, icewind1991 and nfebe and removed request for a team July 22, 2025 15:00
@jplitza jplitza force-pushed the files-external-optional-dependencies branch from 7e371fc to 3d6f8b0 Compare July 22, 2025 15:04
@jplitza jplitza force-pushed the files-external-optional-dependencies branch from 3d6f8b0 to de238bf Compare July 22, 2025 15:12
@jplitza
Copy link
Contributor Author

jplitza commented Jul 22, 2025

I simply cannot understand how my changes would affect the failing tests ("files_sharing: Note to recipient -> shows an existing note when editing a share" timeout), but re-running the failing jobs twice did not fix them…

@skjnldsv
Copy link
Member

skjnldsv commented Jul 23, 2025

@jplitza ignore it, it's very unstable at the moment :)
Thanks for the PR!

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jul 23, 2025
@skjnldsv
Copy link
Member

/backport to stable31

@skjnldsv
Copy link
Member

/backport to stable30

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine I think but I’d like @icewind1991 to check the logic.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

This was referenced Aug 22, 2025
This was referenced Sep 2, 2025
This was referenced Sep 25, 2025
@skjnldsv skjnldsv removed this from the Nextcloud 32 milestone Sep 28, 2025
@skjnldsv skjnldsv added this to the Nextcloud 33 milestone Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 'Invalid storage backend "smb"' when only smbclient is installed

4 participants