Skip to content

feature: add bluesky to accounts #54069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 6 commits into from
Aug 8, 2025
Merged

feature: add bluesky to accounts #54069

skjnldsv merged 6 commits into from
Aug 8, 2025

Conversation

@yemkareems
Copy link
Contributor

@yemkareems yemkareems commented Jul 24, 2025

feature: add bluesky to accounts, show the same in profile edit and visibility option, in view profile and also in sharing tab. Find below screenshots for the same

Screenshot from 2025-07-24 10-12-09 Screenshot from 2025-07-24 10-12-19 Screenshot from 2025-07-24 10-12-37 Screenshot from 2025-07-24 10-12-56
  • Resolves: #

Summary

TODO

  • ...

Checklist

@yemkareems yemkareems added this to the Nextcloud 32 milestone Jul 24, 2025
@yemkareems yemkareems self-assigned this Jul 24, 2025
@yemkareems yemkareems requested review from a team as code owners July 24, 2025 04:46
@yemkareems yemkareems added the 3. to review Waiting for reviews label Jul 24, 2025
@yemkareems yemkareems requested review from artonge and removed request for a team July 24, 2025 04:46
@yemkareems
Copy link
Contributor Author

yemkareems commented Jul 24, 2025

/compile

@nextcloud-command nextcloud-command requested a review from a team as a code owner July 24, 2025 04:51
@yemkareems yemkareems added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 24, 2025
skjnldsv
skjnldsv approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

susnux
susnux reviewed Jul 24, 2025
View reviewed changes
susnux
susnux reviewed Jul 24, 2025
View reviewed changes
susnux
susnux reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks simple and good ✅
Just the verification of the username should be adjusted

@yemkareems
Copy link
Contributor Author

yemkareems commented Jul 27, 2025

/compile

@yemkareems yemkareems added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 27, 2025
susnux
susnux reviewed Jul 27, 2025
View reviewed changes
susnux
susnux reviewed Jul 27, 2025
View reviewed changes
@provokateurin
Copy link
Member

provokateurin commented Jul 28, 2025

All occurrences of bsky in the code should probably be bluesky since that is the full product name and it creates less confusion.

@yemkareems yemkareems mentioned this pull request Jul 30, 2025
Closed
1 task
@yemkareems
Copy link
Contributor Author

yemkareems commented Aug 6, 2025

/compile

@susnux
Copy link
Contributor

susnux commented Aug 6, 2025

/compile rebase

@susnux susnux force-pushed the feature/51791/add-bsky-option-to-accounts branch from 4f67f67 to 5b41c8b Compare August 6, 2025 16:59
susnux
susnux reviewed Aug 6, 2025
View reviewed changes
@susnux susnux force-pushed the feature/51791/add-bsky-option-to-accounts branch from 967a5ec to 2a22fd7 Compare August 7, 2025 13:02
susnux
susnux reviewed Aug 7, 2025
View reviewed changes
@skjnldsv
Copy link
Member

skjnldsv commented Aug 8, 2025

/compile rebase

@skjnldsv skjnldsv enabled auto-merge August 8, 2025 08:05
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish feature: users and groups feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) enhancement and removed 3. to review Waiting for reviews labels Aug 8, 2025
yemkareems and others added 6 commits August 8, 2025 08:06
@yemkareems @nextcloud-command
feat: add bluesky to accounts, show the same in profile edit and visi…
aa227f1 
…bility option, in view profile and also in sharing tab

Signed-off-by: yemkareems <[email protected]>
@susnux @nextcloud-command
chore: update openapi and autoloaders
d36602a 
Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: yemkareems <[email protected]>
@susnux @nextcloud-command
chore: add deprecated IAccountManager::PROPERTY_TWITTER to psalm ba…
d31be34 
…seline

Signed-off-by: Ferdinand Thiessen <[email protected]>
@yemkareems @nextcloud-command
fix: eslint errors fixed in vue file, IAccountManager since added, bl…
4c887ec 
…uesky svg added to REUSE.toml file

Signed-off-by: yemkareems <[email protected]>
@yemkareems @nextcloud-command
fix: fontawesome license text added and vue file linting errors fixed
1b4e967 
Signed-off-by: yemkareems <[email protected]>
@nextcloud-command
chore(assets): Recompile assets
e53ad66 
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the feature/51791/add-bsky-option-to-accounts branch from dd2b865 to e53ad66 Compare August 8, 2025 08:08
@skjnldsv skjnldsv merged commit 93296c2 into master Aug 8, 2025
200 of 202 checks passed
@skjnldsv skjnldsv deleted the feature/51791/add-bsky-option-to-accounts branch August 8, 2025 08:32
This was referenced Aug 11, 2025
Closed
Closed
Closed
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@yemkareems yemkareems

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: users and groups

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@yemkareems @provokateurin @susnux @skjnldsv @nextcloud-command