Skip to content

Conversation

@Jerome-Herbinet
Copy link
Member

I think that ‘All Folders’ creates confusion with ‘All Files’ located above it, because ‘All Files’ also displays folders. I know there is a small chevron next to ‘All Folders’, but it's not very intuitive. I therefore suggest renaming ‘All folders’ to ‘Folder tree’, which better suggests that it is a matter of displaying a folder tree.

2025-07-25_15-22
  • Resolves: #

Summary

TODO

  • ...

Checklist

@Jerome-Herbinet Jerome-Herbinet requested review from a team and skjnldsv as code owners July 25, 2025 13:33
@Jerome-Herbinet Jerome-Herbinet requested review from artonge and sorbaugh and removed request for a team July 25, 2025 13:33
@Jerome-Herbinet Jerome-Herbinet requested a review from a team as a code owner July 25, 2025 13:36
@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: files papercut Annoying recurring UX issue with possibly simple fix. labels Jul 25, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jul 25, 2025
@solracsf
Copy link
Member

A 2-word naming sounds better to me.

Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment but in any case I don't see why this is a separate item in the first place. Couldn't it be merged with All files? By that, I mean just give All files the chevron and only have 1 sidebar item. That sounds like a better solution to me.

@skjnldsv
Copy link
Member

skjnldsv commented Jul 29, 2025

I don't see why this is a separate item in the first place. Couldn't it be merged with All files?

Because that was the initial request for the feature :)
But I think we could absolutely merge this into files yep

@kra-mo kra-mo self-requested a review July 29, 2025 09:05
@Jerome-Herbinet Jerome-Herbinet requested a review from kra-mo July 30, 2025 08:53
@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-folder-tree-structure branch 2 times, most recently from 8a11686 to 738b743 Compare July 31, 2025 08:50
@Jerome-Herbinet
Copy link
Member Author

@kra-mo do you think that cypress errors are really related to the PR ?

@kra-mo
Copy link
Member

kra-mo commented Jul 31, 2025

@kra-mo do you think that cypress errors are really related to the PR ?

Don't know, I'm not a developer :D

@Jerome-Herbinet
Copy link
Member Author

@kra-mo do you think that cypress errors are really related to the PR ?

Don't know, I'm not a developer :D

@skjnldsv ?

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-folder-tree-structure branch from 738b743 to 4283e05 Compare July 31, 2025 11:51
@skjnldsv
Copy link
Member

/compile amend

Signed-off-by: Jérôme Herbinet <[email protected]>
Co-Authored-By: kramo <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the Jerome-Herbinet-folder-tree-structure branch from 4283e05 to ee3e628 Compare July 31, 2025 12:26
@skjnldsv skjnldsv enabled auto-merge July 31, 2025 12:38
@skjnldsv skjnldsv disabled auto-merge July 31, 2025 12:39
@skjnldsv skjnldsv merged commit 5f56ad3 into master Jul 31, 2025
122 of 124 checks passed
@skjnldsv skjnldsv deleted the Jerome-Herbinet-folder-tree-structure branch July 31, 2025 12:39
@skjnldsv
Copy link
Member

Out of date bundles :)
Fixed!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement feature: files feedback-requested papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants