Skip to content

fix(auth): Correct max password length in config.sample.php #54091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(auth): Correct max password length in config.sample.php #54091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions config/config.sample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,21 +474,20 @@
'auth.webauthn.enabled' => true,

/**
* Whether encrypted passwords should be stored in the database
* By default, the passwords are stored (encrypted) in the database, but this can be
* explicitly disabled by admins with special requirements (with various caveats).
*
* The passwords are only decrypted using the login token stored uniquely in the
* clients and allow connecting to external storages, autoconfiguring mail accounts in
* the mail app, and periodically checking if the password is still valid.
* The passwords are only decrypted using the login token stored uniquely in each
* client. The passwords allow connecting to external storages, autoconfiguring mail
* accounts in the mail app, and periodically checking if the password is still valid.
*
* This might be desirable to disable this functionality when using one-time
* passwords or when having a password policy enforcing long passwords (> 300
* characters).
*
* By default, the passwords are stored encrypted in the database.
* It may be desirable to disable this functionality when using one-time passwords
* or when enforcing extremely long passwords (>469 bytes aka:
Copy link
Member

@nickvergessen nickvergessen Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not enforce passwords longer than Max length.
The 300 is because encrypting the password can take significant time when it's longer than 300 characters, so that number should stay.

* `IUserManager::MAX_PASSWORD_LENGTH`).
*
* WARNING: If disabled, password changes on the user backend (e.g., on LDAP) no
* longer log connected clients out automatically. Users can still disconnect
* the clients by deleting the app token from the security settings.
* longer will log clients out automatically. Users can still disconnect a client by
* manually deleting the app token from the security settings.
*/
'auth.storeCryptedPassword' => true,

Expand Down
Loading