Skip to content

Conversation

@miaulalala
Copy link
Contributor

  • Resolves: #

Summary

TODO

  • ...

Checklist

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

@miaulalala miaulalala requested a review from st3iny August 5, 2025 16:49
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But fine in general from my side

@st3iny
Copy link
Member

st3iny commented Aug 11, 2025

@miaulalala Some test failures seem to be related:

1) Test\Activity\ManagerTest::testPublish with data set #0 (null, '')
OCP\Activity\Exceptions\IncompleteActivityException: The given event is invalid

/home/runner/actions-runner/_work/server/server/lib/private/Activity/Manager.php:113
/home/runner/actions-runner/_work/server/server/tests/lib/Activity/ManagerTest.php:244

2) Test\Activity\ManagerTest::testPublish with data set #1 ('test_author', 'test_author')
OCP\Activity\Exceptions\IncompleteActivityException: The given event is invalid

/home/runner/actions-runner/_work/server/server/lib/private/Activity/Manager.php:113
/home/runner/actions-runner/_work/server/server/tests/lib/Activity/ManagerTest.php:244

@st3iny
Copy link
Member

st3iny commented Aug 13, 2025

Looking good now. Squash and merge? :)

@miaulalala miaulalala force-pushed the feat/noid/add-bulk-activity branch from b5a4916 to 2acd492 Compare August 13, 2025 11:30
@st3iny st3iny force-pushed the feat/noid/add-bulk-activity branch from 2acd492 to 2e628e5 Compare August 13, 2025 18:13
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 14, 2025
@miaulalala miaulalala force-pushed the feat/noid/add-bulk-activity branch from 2e628e5 to 6a3a244 Compare August 14, 2025 09:31
@miaulalala miaulalala merged commit 1a2d0d5 into master Aug 14, 2025
242 of 250 checks passed
@miaulalala miaulalala deleted the feat/noid/add-bulk-activity branch August 14, 2025 13:53
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants