-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: validate written size for s3 multipart uploads #54125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Wasn't able to figure out a good solution for single part uploads so far, but smaller files should be less likely to be canceled anyway 🙈 |
0ecec88 to
2687b73
Compare
provokateurin
approved these changes
Jul 28, 2025
solracsf
reviewed
Jul 28, 2025
Member
2687b73 to
214280f
Compare
Member
Author
Ok, I think setting the |
52e5c09 to
c762e86
Compare
susnux
approved these changes
Jul 29, 2025
8ab626b to
7d3ede0
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
7d3ede0 to
97efc95
Compare
Member
Author
|
/backport to stable31 |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multi-part s3 uploads, validate that the chunks add up to the expected size before completing the upload.
This prevents partially uploaded files from being saved in s3.
To test:
curl)This fix applies both on newly created file and overwritten files.