Skip to content

feat(preset): profile visibility #54158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArtificialOwl merged 4 commits into from
Aug 8, 2025
Merged

feat(preset): profile visibility #54158

ArtificialOwl merged 4 commits into from
Aug 8, 2025

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jul 30, 2025 •
edited
Loading

  • create a new PresetManager using parts of ConfigManager
  • fix an issue with default in key details
  • alternate profile visibility based on Preset

@ArtificialOwl ArtificialOwl requested a review from a team as a code owner July 30, 2025 11:11
@ArtificialOwl ArtificialOwl requested review from Altahrim, icewind1991 and sorbaugh and removed request for a team July 30, 2025 11:11
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Jul 30, 2025
@ArtificialOwl ArtificialOwl added this to the Nextcloud 32 milestone Jul 30, 2025
@ArtificialOwl ArtificialOwl mentioned this pull request Jul 30, 2025
Closed
@ArtificialOwl ArtificialOwl force-pushed the feat/preset/profile-visibility+presetmanager branch 5 times, most recently from a22065e to 26023af Compare July 31, 2025 13:02
salmart-dev
salmart-dev approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@salmart-dev salmart-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the whole context for the Lexicon topic, but the changes here make sense with what I could read about it in the linked issue.

come-nc
come-nc approved these changes Aug 7, 2025
View reviewed changes
@ArtificialOwl ArtificialOwl force-pushed the feat/preset/profile-visibility+presetmanager branch from 26023af to bbc9ed1 Compare August 8, 2025 12:01
@ArtificialOwl ArtificialOwl enabled auto-merge August 8, 2025 12:21
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Aug 8, 2025

removing the @SInCE thing,
rebasing,
merging

@ArtificialOwl ArtificialOwl merged commit eaae5e1 into master Aug 8, 2025
196 checks passed
@ArtificialOwl ArtificialOwl deleted the feat/preset/profile-visibility+presetmanager branch August 8, 2025 12:21
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@salmart-dev salmart-dev salmart-dev approved these changes

@come-nc come-nc come-nc approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

7 participants

@ArtificialOwl @icewind1991 @salmart-dev @come-nc @susnux @skjnldsv