fix(core): ensure unique vcategory

[skjnldsv]

• Resolves [Bug]: Incomplete handling for tags with the same name #54087
• Closes Handle tags with the same name gracefully #49674

Summary

[come-nc]

Did I miss it or is there no change apart from the unique index?

[skjnldsv]

Did I miss it or is there no change apart from the unique index?

the removal of duplicates in the migration ?

[come-nc]

Did I miss it or is there no change apart from the unique index?

the removal of duplicates in the migration ?

But that’s fixing the existing, but how did they get in there?
The code path that previously added them will now blow up with a DB exception, no?

[skjnldsv]

But that’s fixing the existing, but how did they get in there? The code path that previously added them will now blow up with a DB exception, no?

As far as I understood, it's some very edge case where on a race condition, we cache the list of existing tags which means we can allow multiple to be created because the tag existing check won't have the most recent list.

Erroring out is ok from me 🤷
The goal is to fix the existing data and preventing it from happening again.
Allowing to handle favorites again

[skjnldsv]

/backport to stable31

[skjnldsv]

/backport to stable30

[kesselb]

Thanks 🙏

[backportbot]

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/54165/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9aac1821

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/54165/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[backportbot]

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/54165/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9aac1821

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/54165/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[nickvergessen]

It doesn't?

[skjnldsv]

Leftover comment from previous approach.