Skip to content

chore: remove nextcloud-vue-collections and use @nextcloud/vue instead #54171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Jul 31, 2025
Merged

chore: remove nextcloud-vue-collections and use @nextcloud/vue instead #54171

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f86c4
chore: remove `nextcloud-vue-collections` and use `@nextcloud/vue` in…
susnux Jul 31, 2025
5c768aa
chore(assets): Recompile assets
nextcloud-command Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: remove nextcloud-vue-collections and use @nextcloud/vue in… 
…stead

`nextcloud-vue-collections` is deprecated for quite some time and was
merged into `@nextcloud/vue`. So lets drop that dependency.

Adjust the two files where it was used, one of them was itself never
used so just dropped that file.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Jul 31, 2025
commit 48f86c4696a16f4deae4341c42b213e35d720c34
36 changes: 0 additions & 36 deletions apps/files_sharing/src/views/CollaborationView.vue
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions apps/files_sharing/src/views/SharingTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
<div v-if="projectsEnabled"
v-show="!showSharingDetailsView && fileInfo"
class="sharingTab__additionalContent">
<CollectionList :id="`${fileInfo.id}`"
<NcCollectionList :id="`${fileInfo.id}`"
type="file"
:name="fileInfo.name" />
</div>
Expand All @@ -161,16 +161,16 @@ import { getCapabilities } from '@nextcloud/capabilities'
import { orderBy } from '@nextcloud/files'
import { loadState } from '@nextcloud/initial-state'
import { generateOcsUrl } from '@nextcloud/router'
import { CollectionList } from 'nextcloud-vue-collections'
import { ShareType } from '@nextcloud/sharing'

import InfoIcon from 'vue-material-design-icons/InformationOutline.vue'
import NcAvatar from '@nextcloud/vue/components/NcAvatar'
import NcButton from '@nextcloud/vue/components/NcButton'
import NcCollectionList from '@nextcloud/vue/components/NcCollectionList'
import NcPopover from '@nextcloud/vue/components/NcPopover'
import InfoIcon from 'vue-material-design-icons/InformationOutline.vue'

import axios from '@nextcloud/axios'
import moment from '@nextcloud/moment'
import NcAvatar from '@nextcloud/vue/components/NcAvatar'
import NcButton from '@nextcloud/vue/components/NcButton'

import { shareWithTitle } from '../utils/SharedWithMe.js'

Expand All @@ -192,10 +192,10 @@ export default {
name: 'SharingTab',

components: {
CollectionList,
InfoIcon,
NcAvatar,
NcButton,
NcCollectionList,
NcPopover,
SharingEntryInternal,
SharingEntrySimple,
Expand Down
29 changes: 1 addition & 28 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"@simplewebauthn/browser": "^13.1.0",
"@vue/web-component-wrapper": "^1.3.0",
"@vueuse/components": "^11.3.0",
"@vueuse/core": "^11.0.1",
"@vueuse/core": "^11.3.0",
"@vueuse/integrations": "^11.3.0",
"backbone": "^1.6.1",
"blueimp-md5": "^2.19.0",
Expand All @@ -91,7 +91,6 @@
"marked": "^15.0.12",
"moment": "^2.30.1",
"moment-timezone": "^0.6.0",
"nextcloud-vue-collections": "^0.13.0",
"p-limit": "^6.2.0",
"p-queue": "^8.1.0",
"path": "^0.12.7",
Expand Down
Loading