Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Aug 1, 2025

  • Resolves: #

Summary

I converted the current CodeQL integration to an action according to the guide from GitHub. I also added the dist directory to the ignore list.

CodeQL failure is expected until an admin disables the default integration:

Error: Code Scanning could not process the submitted SARIF file:
CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled

Checklist

@st3iny st3iny self-assigned this Aug 1, 2025
@st3iny st3iny requested a review from a team as a code owner August 1, 2025 07:54
@st3iny st3iny added the 3. to review Waiting for reviews label Aug 1, 2025
@st3iny st3iny requested review from ChristophWurst, come-nc, icewind1991, kesselb and leftybournes and removed request for a team August 1, 2025 07:54
pull_request:
branches: [ "master", "stable*" ]
schedule:
- cron: '28 18 * * 1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oddly specific?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is from GitHub's generated template. It was generated from our default configuration and I just copied it.

Of course, we can change it. I personally believe that the pull_request trigger is sufficient and we don't need push and shedule triggers.

@kesselb kesselb merged commit 9c79483 into master Aug 4, 2025
244 of 261 checks passed
@kesselb kesselb deleted the ci/codeql/convert-to-action branch August 4, 2025 10:10
@st3iny
Copy link
Member Author

st3iny commented Aug 4, 2025

It's working: #54236

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants