Skip to content

[TaskProcessing] Load and store some config keys lazily #54196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 4 commits into from
Aug 5, 2025
Merged

[TaskProcessing] Load and store some config keys lazily #54196

nickvergessen merged 4 commits into from
Aug 5, 2025

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Aug 1, 2025 •
edited
Loading

Switch to OCP\IAppConfig in some places. Load and store ai.taskprocessing_type_preferences and ai.taskprocessing_provider_preferences "core" values as lazy.

Those values are loaded often but they are cached:

  • 60 seconds for ai.taskprocessing_type_preferences
  • 3 minutes for ai.taskprocessing_provider_preferences

@julien-nc julien-nc added this to the Nextcloud 32 milestone Aug 1, 2025
@julien-nc julien-nc force-pushed the enh/noid/taskprocessing-lazy-config branch from d47e7ba to cd3cd1a Compare August 1, 2025 10:03
@julien-nc julien-nc marked this pull request as ready for review August 1, 2025 12:49
@julien-nc julien-nc requested a review from a team as a code owner August 1, 2025 12:49
@julien-nc julien-nc requested review from nfebe, provokateurin and salmart-dev and removed request for a team August 1, 2025 12:49
marcelklehr
marcelklehr reviewed Aug 1, 2025
View reviewed changes
@julien-nc julien-nc force-pushed the enh/noid/taskprocessing-lazy-config branch from 9bf624d to a236b73 Compare August 1, 2025 13:36
@julien-nc
Copy link
Member Author

julien-nc commented Aug 1, 2025 •
edited
Loading

Cypress failures not related:

  • files_sharing/note-to-recipient.cy.ts

@julien-nc julien-nc force-pushed the enh/noid/taskprocessing-lazy-config branch from a236b73 to be7ef43 Compare August 4, 2025 08:11
@julien-nc julien-nc requested review from artonge and come-nc August 4, 2025 09:36
@nickvergessen nickvergessen merged commit ff30433 into master Aug 5, 2025
218 of 226 checks passed
@nickvergessen nickvergessen deleted the enh/noid/taskprocessing-lazy-config branch August 5, 2025 10:28
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@marcelklehr marcelklehr marcelklehr approved these changes

@Altahrim Altahrim Altahrim approved these changes

@kyteinsky kyteinsky kyteinsky approved these changes

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: text processing performance 🚀

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

7 participants

@julien-nc @nickvergessen @marcelklehr @Altahrim @kyteinsky @skjnldsv