perf: join array_merge calls in MountProvider::getMountsForUser() #54229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
requested review from
Altahrim,
nfebe and
salmart-dev
and removed request for
a team
nickvergessen
approved these changes
Aug 4, 2025
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Good in general, but the code in question is in recent discussions about performance, so could create conflicts for backports etc.
Maybe this can be done after the perf week?
Altahrim
approved these changes
Aug 4, 2025
st3iny
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Won't do much but prevents unnecessary array copies.
Checklist