fix: Remove redundant toast notifications #54260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
skjnldsv
approved these changes
Aug 5, 2025
susnux
approved these changes
Aug 5, 2025
joshtrichards
requested changes
Aug 6, 2025
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Nice polish. Thanks for streamlining the toasts, @kra-mo!
kra-mo
force-pushed
the
fix/less-useless-toasts
branch
2 times, most recently
from
ba6d020 to
3f38cda
Compare
Member
|
/compile rebase |
joshtrichards
approved these changes
Aug 7, 2025
Since these actions already have highly visible visual confirmation, no extra notifications are needed. Split out from #54202 Signed-off-by: kramo <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/less-useless-toasts
branch
from
3f38cda to
da3a4c6
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #54202
Summary
Since these actions already have highly visible visual confirmation, no extra notifications are needed.
Checklist