Skip to content

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Aug 6, 2025

Partially fix #54274

Summary

First query metadata for live photo and then delete the metadata, by making the SyncLivePhotosListener priority higher than the default.

Order of query before:

image

Order of query after:

image

Checklist

@CarlSchwan CarlSchwan requested a review from a team as a code owner August 6, 2025 12:27
@CarlSchwan CarlSchwan requested review from ArtificialOwl, artonge, come-nc and salmart-dev and removed request for a team August 6, 2025 12:27
@CarlSchwan CarlSchwan force-pushed the fix-order-metadata-deletion branch from 3b26682 to ff6d8b0 Compare August 6, 2025 12:31
@susnux susnux added this to the Nextcloud 32 milestone Aug 6, 2025
@susnux susnux added bug 3. to review Waiting for reviews labels Aug 6, 2025
@CarlSchwan CarlSchwan self-assigned this Aug 6, 2025
@CarlSchwan CarlSchwan force-pushed the fix-order-metadata-deletion branch from ff6d8b0 to ad8efbc Compare August 6, 2025 14:40
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment above the registration explaining why would be good

First query metadata for live photo and then delete the metadata, by
making the SyncLivePhotosListener priority higher than the default.

Partially fix #54274

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan force-pushed the fix-order-metadata-deletion branch from ad8efbc to 9fef97c Compare August 7, 2025 09:19
@CarlSchwan
Copy link
Member Author

A comment above the registration explaining why would be good

done

@CarlSchwan CarlSchwan merged commit 43aa92f into master Aug 7, 2025
196 checks passed
@CarlSchwan CarlSchwan deleted the fix-order-metadata-deletion branch August 7, 2025 13:04
@CarlSchwan
Copy link
Member Author

/backport to stable31

@CarlSchwan
Copy link
Member Author

/backport to stable30

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Un-optimized and buggy deletion of metadata

5 participants