Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 6, 2025

Summary

After the outline icon switch

Before After
2025-08-06_15-44 2025-08-06_15-44_1

Checklist

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Aug 6, 2025
@skjnldsv skjnldsv self-assigned this Aug 6, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner August 6, 2025 13:46
@skjnldsv skjnldsv added the bug label Aug 6, 2025
@skjnldsv skjnldsv requested review from susnux and removed request for a team August 6, 2025 13:46
@skjnldsv skjnldsv added the design Design, UI, UX, etc. label Aug 6, 2025
@skjnldsv skjnldsv requested review from nfebe and sorbaugh August 6, 2025 13:46
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 6, 2025

Regarding the alignment, I think it requires a vue lib update, because I cannot reproduce the issue on our components 🤔

margin-inline-start: calc(var(--default-grid-baseline) * 2);
span.pencil-icon {
span.pencil-outline-icon {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just give it a proper custom class

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah... 😅

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 7, 2025

/compile rebase

@nextcloud-command nextcloud-command requested a review from a team as a code owner August 7, 2025 07:47
@skjnldsv skjnldsv enabled auto-merge August 7, 2025 08:55
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@skjnldsv skjnldsv merged commit 2e0baa5 into master Aug 7, 2025
124 checks passed
@skjnldsv skjnldsv deleted the fix/tags-icon branch August 7, 2025 09:57
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: tags regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants