Skip to content

Conversation

@salmart-dev
Copy link
Contributor

@salmart-dev salmart-dev commented Aug 7, 2025

Summary

This PR:

  • is based off the work in Monitor and report apps doing per-file propfind discovery #54114
  • updates reporting that will be introduced from the above issue to track collection preload queries
  • emits a new event preloadCollection in the DAV server to notify interested plugins that they can preload properties for a collection if needed.
  • updates existing core plugins to use the preloadCollection

TODO

  • Add documentation
  • Add tests

Checklist

@salmart-dev salmart-dev force-pushed the feat/54115/emitPreloadCollectionEvent branch from 5386aaa to 8542545 Compare August 7, 2025 15:42
@salmart-dev salmart-dev force-pushed the feat/54114/reportSlowPropfinds branch 2 times, most recently from a86009a to c62a214 Compare August 7, 2025 16:03
@salmart-dev salmart-dev force-pushed the feat/54115/emitPreloadCollectionEvent branch 2 times, most recently from ebacdb1 to 27cba0e Compare August 7, 2025 16:08
@salmart-dev salmart-dev marked this pull request as ready for review August 8, 2025 11:21
@salmart-dev salmart-dev requested review from come-nc, icewind1991 and nfebe and removed request for a team August 8, 2025 11:21
@salmart-dev salmart-dev self-assigned this Aug 8, 2025
@salmart-dev salmart-dev force-pushed the feat/54115/emitPreloadCollectionEvent branch from 18d34ec to a12abcc Compare August 11, 2025 11:44
@salmart-dev salmart-dev force-pushed the feat/54114/reportSlowPropfinds branch from 1395d1c to b936ef2 Compare August 13, 2025 08:18
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CalDAV related changes look good!

@st3iny
Copy link
Member

st3iny commented Aug 13, 2025

There are many conflicts though.

@salmart-dev
Copy link
Contributor Author

There are many conflicts though.

The target branch is not master but the branch that introduces logging, they will get solved once I rebase again on the latest version of that branch.

@salmart-dev salmart-dev force-pushed the feat/54114/reportSlowPropfinds branch from b936ef2 to ec176a9 Compare August 13, 2025 17:46
Base automatically changed from feat/54114/reportSlowPropfinds to master August 14, 2025 11:40
@salmart-dev salmart-dev force-pushed the feat/54115/emitPreloadCollectionEvent branch from a12abcc to 23d4d69 Compare August 14, 2025 15:06
@salmart-dev salmart-dev removed the 3. to review Waiting for reviews label Aug 14, 2025
@salmart-dev salmart-dev added the 4. to release Ready to be released and/or waiting for tests to finish label Aug 14, 2025
This allows plugins to preload the content of a Collection to speed-up
subsequent per-node PROPFINDs and reduce database load.

Signed-off-by: Salvatore Martire <[email protected]>
@salmart-dev salmart-dev force-pushed the feat/54115/emitPreloadCollectionEvent branch from 23d4d69 to 4a0a00a Compare August 15, 2025 08:46
@salmart-dev salmart-dev enabled auto-merge August 15, 2025 08:47
@salmart-dev salmart-dev merged commit 75d9aaa into master Aug 15, 2025
196 checks passed
@salmart-dev salmart-dev deleted the feat/54115/emitPreloadCollectionEvent branch August 15, 2025 09:06
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish performance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement batched property fetching API for DAV plugins to optimize propfind performance

4 participants