Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 8, 2025

Summary

In the table header, we only want actions that do have a batch option defined.
We do allow top-level actions without batch option if they're top-level parents and have valid children (i.e having an execBatch method defined) here

Checklist

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Aug 8, 2025
@skjnldsv skjnldsv self-assigned this Aug 8, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner August 8, 2025 07:34
@skjnldsv skjnldsv requested review from nfebe, sorbaugh and susnux and removed request for a team August 8, 2025 07:34
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 8, 2025

/compile rebase

@nextcloud-command nextcloud-command force-pushed the fix/files-batch-actions branch from 5672377 to 149434a Compare August 8, 2025 07:42
@nextcloud-command nextcloud-command requested a review from a team as a code owner August 8, 2025 07:42
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 8, 2025

/backport 68404d5 to stable31

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 8, 2025

/backport 68404d5 to stable30

@skjnldsv skjnldsv enabled auto-merge August 8, 2025 09:49
@skjnldsv
Copy link
Member Author

/compile rebase

@nextcloud-bot nextcloud-bot mentioned this pull request Aug 22, 2025
@AndyScherzinger
Copy link
Member

/compile rebase

@skjnldsv skjnldsv merged commit 301f567 into master Aug 22, 2025
126 checks passed
@skjnldsv skjnldsv deleted the fix/files-batch-actions branch August 22, 2025 18:34
@backportbot
Copy link

backportbot bot commented Aug 22, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/54329/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 68404d5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/54329/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Setting reminder with multi select files menu fails

5 participants