Skip to content

feat(lexicon): get value type from lexicon #54335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArtificialOwl merged 2 commits into from
Aug 22, 2025
Merged

feat(lexicon): get value type from lexicon #54335

ArtificialOwl merged 2 commits into from
Aug 22, 2025
+25 −9

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Aug 8, 2025 •
edited
Loading

  • get expected type when setting value from front-end
  • convert instead of cast, so that 'yes' is considered boolean

@ArtificialOwl ArtificialOwl requested a review from a team as a code owner August 8, 2025 12:44
@ArtificialOwl ArtificialOwl requested review from Altahrim, CarlSchwan and yemkareems and removed request for a team August 8, 2025 12:44
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Aug 8, 2025
@ArtificialOwl ArtificialOwl added this to the Nextcloud 32 milestone Aug 8, 2025
@ArtificialOwl ArtificialOwl force-pushed the feat/noid/lexicon-appconfig-controller branch from d51a7d3 to ab3dc52 Compare August 21, 2025 14:05
@ArtificialOwl ArtificialOwl force-pushed the feat/noid/lexicon-appconfig-controller branch from ab3dc52 to 4f0d563 Compare August 21, 2025 14:17
@ArtificialOwl ArtificialOwl merged commit 2975a99 into master Aug 22, 2025
230 of 238 checks passed
@ArtificialOwl ArtificialOwl deleted the feat/noid/lexicon-appconfig-controller branch August 22, 2025 13:27
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 22, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@ArtificialOwl @artonge @CarlSchwan @skjnldsv