Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
views/UnifiedSearch: trigger on f input rather than qwerty keycode
Before, search would trigger based on the physical keycode of the pressed key;
whether that key would _represent_ f on a qwerty keyboard.

Anyone not typing qwerty will have search trigger on the same physical button,
regardless of whether that button actually types `f` in their respective layout.

In my case, I use neo_qwerty which has a layer where the arrow keys are on ESDF.
Attempting to jump forward word-wise using `C-<right>` causes global search to
open because `<right>` is where f would be on qwerty.

Any user with a keyboard layout other than qwerty should be affected by this
bug.

This makes it so that you have to press the `f` key of your particular layout;
wherever that may be.

Signed-off-by: Atemu <[email protected]>
  • Loading branch information
Atemu authored Aug 9, 2025
commit e99ba63d922597a660786f45d481e985c6c71fac
2 changes: 1 addition & 1 deletion core/src/views/UnifiedSearch.vue
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export default defineComponent({
* @param event The keyboard event
*/
onKeyDown(event: KeyboardEvent) {
if (event.ctrlKey && event.code === 'KeyF') {
if (event.ctrlKey && event.key === 'f') {
// only handle search if not already open - in this case the browser native search should be used
if (!this.showLocalSearch && !this.showUnifiedSearch) {
event.preventDefault()
Expand Down
Loading