Skip to content

feat(AppConfig): cache the config if local cache is available #54383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 6 commits into from
Aug 18, 2025
Merged

feat(AppConfig): cache the config if local cache is available #54383

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c85548
feat(AppConfig): cache app config in local cache if available
susnux Aug 12, 2025
9d320f8
test(AppConfig): add proper unit tests
susnux Aug 13, 2025
d5e2432
fix: resolve invalid usage of `AppConfig::getValue`
susnux Aug 12, 2025
0ef58c9
refactor(Memcache\Factory): move prefix generation to the factory class
susnux Aug 12, 2025
866ccae
docs(IConfig): fix wrong doc block type for `$key` on `setAppValue`
susnux Aug 13, 2025
503f43f
test(cypress): clear cache after running OCC commands
susnux Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(AppConfig): cache app config in local cache if available 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Aug 18, 2025
commit 1c85548f8635284b255dc6e0743e99cc408342e8
5 changes: 0 additions & 5 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3314,11 +3314,6 @@
<code><![CDATA[version_compare($first, $second, $operator)]]></code>
</NullableReturnStatement>
</file>
<file src="lib/private/AppConfig.php">
<NullableReturnStatement>
<code><![CDATA[$this->fastCache[$app][$key] ?? $default]]></code>
</NullableReturnStatement>
</file>
<file src="lib/private/AppFramework/Bootstrap/FunctionInjector.php">
<UndefinedMethod>
<code><![CDATA[getName]]></code>
Expand Down
9 changes: 9 additions & 0 deletions config/config.sample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1792,6 +1792,15 @@
*/
'cache_chunk_gc_ttl' => 60*60*24,

/**
* Enable caching of the app config values.
* If enabled the app config will be cached locally for a short TTL,
* reducing database load significatly on larger setups.
*
* Defaults to ``true``
*/
'cache_app_config' => true,

/**
* Using Object Store with Nextcloud
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/private/AllConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public function setAppValue($appName, $key, $value) {
* @deprecated 29.0.0 Use {@see IAppConfig} directly
*/
public function getAppValue($appName, $key, $default = '') {
return \OC::$server->get(AppConfig::class)->getValue($appName, $key, $default);
return \OC::$server->get(AppConfig::class)->getValue($appName, $key, $default) ?? $default;
}

/**
Expand Down
Loading