Skip to content

perf(properties): Remove useless calendar-enabled rows #54404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CarlSchwan wants to merge 1 commit into from
Closed

perf(properties): Remove useless calendar-enabled rows #54404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
perf(properties): Remove useless calendar-enabled rows 
Instead of setting calendar-enabled to true, delete the row as true is
the default value anyway. This should make the oc_properties table a bit
smaller as calendar-enabled is the properties the most often set.

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
Carl Schwan committed Aug 13, 2025
commit e230cc8705d6dd2a36b123fdd3ba58fd609c6043
2 changes: 1 addition & 1 deletion apps/dav/lib/DAV/CustomPropertiesBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ private function updateProperties(string $path, array $properties): bool {
];

// If it was null, we need to delete the property
if (is_null($propertyValue)) {
if (is_null($propertyValue) || ($propertyName === '{http://owncloud.org/ns}calendar-enabled' && $propertyValue === '1')) {
if (array_key_exists($propertyName, $existing)) {
$deleteQuery = $deleteQuery ?? $this->createDeleteQuery();
$deleteQuery
Expand Down
Loading