perf: ignore any custom property in the nc/oc namespace that isn't explicitly allowed #54411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
ArtificialOwl,
CarlSchwan and
provokateurin
and removed request for
a team
icewind1991
changed the title
icewind1991
force-pushed
the
dav-customerproperties-ignore-nc
branch
from
a1a7d50 to
d958b17
Compare
st3iny
approved these changes
Aug 13, 2025
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Should be fine. I can't think of other CalDAV/CardDAV related properties that are missing here.
…explicitly allowed Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
dav-customerproperties-ignore-nc
branch
from
c12de5c to
46b5ff7
Compare
CarlSchwan
approved these changes
Aug 14, 2025
Member
Author
|
/backport to stable31 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying (and failing) to keep a list of known properties to ignore, just ignore everything in our namespace by default.