perf: render sharing tab sections only once #54413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
requested review from
skjnldsv,
susnux and
szaimen
and removed request for
a team
st3iny
force-pushed
the
perf/render-sharing-tab-sections-only-once
branch
from
358ac7a to
cb0e8e8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
st3iny
force-pushed
the
perf/render-sharing-tab-sections-only-once
branch
from
cb0e8e8 to
9d5819b
Compare
st3iny
commented
Aug 13, 2025
Comment on lines
-134
to
+133
| <component :is="section($refs['section-'+index], fileInfo)" :file-info="fileInfo" /> | ||
| <component :is="component" :file-info="fileInfo" /> |
Member
Author
There was a problem hiding this comment.
The problem was here. The section callback was executed twice during render. Now it is cached via a computed property.
szaimen
approved these changes
Aug 13, 2025
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
LGTM, saw it working on Richards PC in the related resources app and group folders app :)
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
perf/render-sharing-tab-sections-only-once
branch
from
d6bd320 to
798f373
Compare
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before: Related resources are loaded twice each time the sharing sidebar is open.
After: Is only loaded once.
I noticed that the first parameter of the section callback (el) is always undefined. This has been the case since January and it is not used inside any app in the Nextcloud org.
Checklist