Skip to content

[stable31] fix(search): Fix SearchComposer.php filtering logic #54423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 7 commits into from
Aug 18, 2025
Merged

[stable31] fix(search): Fix SearchComposer.php filtering logic #54423

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91d4437
fix(search): Fix SearchComposer.php filtering logic
printminion-co Jul 28, 2025
5339e61
test(SearchComposerTest): add unit tests for SearchComposer
printminion-co Jul 29, 2025
09172cf
test(SearchComposerTest): add test for handling unknown search provider
printminion-co Jul 29, 2025
dae4cfb
test(SearchComposerTest): add unit test for getProviders with multipl…
printminion-co Jul 29, 2025
291c35c
test(SearchComposerTest): add test for provider icon generation
printminion-co Jul 30, 2025
407f7a1
test(SearchComposerTest): add unit tests for getProviders with allowe…
printminion-co Jul 29, 2025
8150036
test(SearchComposerTest): add unit test for getProviders with mixed o…
printminion-co Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(SearchComposerTest): add test for handling unknown search provider 
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
  • Loading branch information
@printminion-co @backportbot
printminion-co authored and backportbot[bot] committed Aug 14, 2025
commit 09172cfe690f8b0d4178af21da8126c87055bfae
15 changes: 15 additions & 0 deletions tests/lib/Search/SearchComposerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@

namespace Test\Search;

use InvalidArgumentException;
use OC\AppFramework\Bootstrap\Coordinator;
use OC\Search\SearchComposer;
use OCP\IAppConfig;
use OCP\IURLGenerator;
use OCP\IUser;
use OCP\Search\ISearchQuery;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Container\ContainerInterface;
use Psr\Log\LoggerInterface;
Expand Down Expand Up @@ -58,4 +61,16 @@ public function testGetProvidersWithNoRegisteredProviders(): void {
$this->assertIsArray($providers);
$this->assertEmpty($providers);
}

public function testSearchWithUnknownProvider(): void {
$this->setupEmptyRegistrationContext();

$user = $this->createMock(IUser::class);
$query = $this->createMock(ISearchQuery::class);

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('Provider unknown_provider is unknown');

$this->searchComposer->search($user, 'unknown_provider', $query);
}
}