Skip to content

perf: prevent fetching a principal's user account if the data is not needed #54426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
st3iny merged 1 commit into from
Aug 28, 2025
Merged

perf: prevent fetching a principal's user account if the data is not needed #54426

st3iny merged 1 commit into from
Aug 28, 2025

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Aug 14, 2025 •
edited
Loading

  • Resolves: #

Summary

Gets rid of most oc_accounts queries. The data was fetched and then discarded right away in some cases.

Checklist

@st3iny st3iny self-assigned this Aug 14, 2025
@st3iny st3iny added enhancement 2. developing Work in progress performance 🚀 feature: caldav Related to CalDAV internals labels Aug 14, 2025
@st3iny st3iny added this to the Nextcloud 32 milestone Aug 14, 2025
@st3iny st3iny changed the title perf: prevent fetching a principal's user account if the data is not … perf: prevent fetching a principal's user account if the data is not needed Aug 14, 2025
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 15, 2025
@st3iny st3iny marked this pull request as ready for review August 15, 2025 13:30
@st3iny st3iny requested review from ArtificialOwl, leftybournes and salmart-dev and removed request for a team August 15, 2025 13:30
@AndyScherzinger AndyScherzinger force-pushed the perf/prevent-fetching-account branch from 9b2c8ca to 857a008 Compare August 19, 2025 22:15
This was referenced Aug 22, 2025
Merged
Merged
Merged
@st3iny st3iny force-pushed the perf/prevent-fetching-account branch 2 times, most recently from fad8704 to 7f3c53c Compare August 28, 2025 11:49
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 28, 2025
@st3iny st3iny force-pushed the perf/prevent-fetching-account branch from 7f3c53c to af3dc0f Compare August 28, 2025 12:05
@st3iny st3iny force-pushed the perf/prevent-fetching-account branch from af3dc0f to 5b254ea Compare August 28, 2025 12:13
@st3iny st3iny enabled auto-merge August 28, 2025 12:14
@st3iny st3iny merged commit 40117dc into master Aug 28, 2025
239 of 252 checks passed
@st3iny st3iny deleted the perf/prevent-fetching-account branch August 28, 2025 14:59
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@st3iny st3iny

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: caldav Related to CalDAV internals performance 🚀

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@st3iny @CarlSchwan @SebastianKrupinski @skjnldsv