Skip to content

fix(caldav): encode calendar URLs properly when formatting search results #54440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Aug 19, 2025
Merged

fix(caldav): encode calendar URLs properly when formatting search results #54440

provokateurin merged 1 commit into from
Aug 19, 2025

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Aug 15, 2025 •
edited
Loading

Summary

Need to encode user IDs properly before including them in URLs.

Checklist

@st3iny st3iny added this to the Nextcloud 32 milestone Aug 15, 2025
@st3iny st3iny self-assigned this Aug 15, 2025
@st3iny st3iny requested a review from a team as a code owner August 15, 2025 12:53
@st3iny st3iny requested review from icewind1991 and removed request for a team August 15, 2025 12:53
@st3iny st3iny added the bug label Aug 15, 2025
@st3iny st3iny added 3. to review Waiting for reviews feature: search feature: caldav Related to CalDAV internals labels Aug 15, 2025
@st3iny
Copy link
Member Author

st3iny commented Aug 15, 2025

/backport to stable31

@st3iny
Copy link
Member Author

st3iny commented Aug 15, 2025

/backport to stable30

@provokateurin provokateurin merged commit c2437eb into master Aug 19, 2025
210 of 214 checks passed
@provokateurin provokateurin deleted the fix/caldav/search-uid-urlencode branch August 19, 2025 09:52
This was referenced Aug 19, 2025
Merged
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@l00v3 l00v3 mentioned this pull request Oct 7, 2025
Closed
4 tasks
@st3iny st3iny mentioned this pull request Oct 8, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@provokateurin provokateurin provokateurin approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@st3iny st3iny

Labels

3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals feature: search

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: Calendar search generates invalid links when username contains spaces

5 participants

@st3iny @ChristophWurst @provokateurin @skjnldsv