Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Aug 16, 2025

Summary

  1. Move timezone configuration of user to the personal settings instead of calendar availability
  2. Provide timezone as current users capability so we can use it in clients and frontend

IMHO this makes it much easier to discover setting the timezone of oneself.

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Aug 16, 2025
@susnux susnux requested a review from st3iny August 16, 2025 21:55
@susnux susnux requested review from a team as code owners August 16, 2025 21:55
@susnux susnux requested review from nfebe and skjnldsv and removed request for a team August 16, 2025 21:55
@susnux susnux added the 3. to review Waiting for reviews label Aug 16, 2025
@susnux susnux requested review from Altahrim and sorbaugh and removed request for a team August 16, 2025 21:55
@susnux susnux force-pushed the feat/central-timezone-setting branch from a1c9251 to c00c29d Compare August 17, 2025 21:45
@susnux susnux requested a review from provokateurin as a code owner August 17, 2025 21:45
@skjnldsv
Copy link
Member

I do wonder if there isn't a part missing regarding the sync of the property with federation. This is quite a mess, but I do remember some area I had to touch when adding the pronouns that I don't see here 🤔
Worth double checking 😊

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\OC\Authentication\Login\SetUserTimezoneCommand still sets the timezone at login and potentially overwrites what the user has set manually. Should the login chain command perhaps only set the timezone value when it hasn't been set before?

@susnux susnux force-pushed the feat/central-timezone-setting branch from c00c29d to bbf64f7 Compare August 18, 2025 10:00
@susnux
Copy link
Contributor Author

susnux commented Aug 18, 2025

Should the login chain command perhaps only set the timezone value when it hasn't been set before?

Yes this makes sense, but we still need the login timezone in the session.
Added this as a new commit.

@susnux susnux requested a review from ChristophWurst August 18, 2025 10:01
@susnux susnux force-pushed the feat/central-timezone-setting branch from bbf64f7 to 20777e4 Compare August 18, 2025 10:40
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Could you add a test case for the existing timezone to \Test\Authentication\Login\SetUserTimezoneCommandTest please?

@ChristophWurst
Copy link
Member

Could you add a test case for the existing timezone to \Test\Authentication\Login\SetUserTimezoneCommandTest please?

Nvm, you pushed that a minute ago 😄

@susnux
Copy link
Contributor Author

susnux commented Aug 18, 2025

Nvm, you pushed that a minute ago 😄

Yes sorry I just squashed the fixup of it 🙈

susnux added 2 commits August 18, 2025 12:46
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux requested a review from a team as a code owner August 18, 2025 10:47
@susnux susnux merged commit 2fb1cfe into master Aug 18, 2025
206 of 208 checks passed
@susnux susnux deleted the feat/central-timezone-setting branch August 18, 2025 12:20
@susnux susnux self-assigned this Aug 18, 2025
@susnux susnux moved this to ☑️ Done in 📁 Files team Aug 18, 2025
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

Create a centralised setting for users to set their timezone

5 participants