-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: allow to set your local timezone in settings and provide it to clients #54470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a1c9251 to
c00c29d
Compare
|
I do wonder if there isn't a part missing regarding the sync of the property with federation. This is quite a mess, but I do remember some area I had to touch when adding the pronouns that I don't see here 🤔 |
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\OC\Authentication\Login\SetUserTimezoneCommand still sets the timezone at login and potentially overwrites what the user has set manually. Should the login chain command perhaps only set the timezone value when it hasn't been set before?
c00c29d to
bbf64f7
Compare
Yes this makes sense, but we still need the login timezone in the session. |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…t set Signed-off-by: Ferdinand Thiessen <[email protected]>
It is handled in personal settings now. Signed-off-by: Ferdinand Thiessen <[email protected]>
bbf64f7 to
20777e4
Compare
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Could you add a test case for the existing timezone to \Test\Authentication\Login\SetUserTimezoneCommandTest please?
Nvm, you pushed that a minute ago 😄 |
Yes sorry I just squashed the fixup of it 🙈 |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Summary
IMHO this makes it much easier to discover setting the timezone of oneself.
Checklist