Skip to content

fix(core): Don't set samesite cookies on status.php #54528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sshambar wants to merge 1 commit into from
Closed

fix(core): Don't set samesite cookies on status.php #54528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,10 +548,11 @@ private static function performSameSiteCookieProtection(IConfig $config): void {
return;
}

$requestUri = $request->getScriptName();
$processingScript = explode('/', $requestUri);
$processingScript = $processingScript[count($processingScript) - 1];

if (count($_COOKIE) > 0) {
$requestUri = $request->getScriptName();
$processingScript = explode('/', $requestUri);
$processingScript = $processingScript[count($processingScript) - 1];

if ($processingScript === 'index.php' // index.php routes are handled in the middleware
|| $processingScript === 'cron.php' // and cron.php does not need any authentication at all
Expand All @@ -573,7 +574,12 @@ private static function performSameSiteCookieProtection(IConfig $config): void {
exit();
}
}
} elseif (!isset($_COOKIE['nc_sameSiteCookielax']) || !isset($_COOKIE['nc_sameSiteCookiestrict'])) {
} else {
// Session not started for status.php, skip setting SS cookies
if ($processingScript === 'status.php') {
return;
}
// set nc_sameSiteCookielax and nc_sameSiteCookiestrict
self::sendSameSiteCookies();
}
}
Expand Down