-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(theming): add new default background for Nextcloud 32 #54554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! :) Just to block this from merging (or could be done in a follow-up):
- Can you make sure that the globe background is moved into the other backgrounds that can be picked? (if those don’t support both light and dark yet it’s fine to separate them into 2 different backgrounds)
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As usual, @susnux is way ahead of me, so this is getting approved! :D Awesome work by Jo and thanks for implementing it!
|
Cypress theming tests are related - will fix it after lunch. |
With Nextcloud 32 we ship a new default background: "Fluid" by Jo Myoung Hee. Copyright by Nextcloud GmbH under the CC-BY-SA-4.0 - added the background compressed as WebP (90% quality) - set as new default - added license reference and move theming related reuse config Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
c0534f2 to
591601d
Compare
Summary
With Nextcloud 32 we ship a new default background: "Fluid" by Jo Myoung Hee. Copyright by Nextcloud GmbH under the CC-BY-SA-4.0
Checklist