Skip to content

[stable31] fix(files_sharing): sharing status action permission and sidebar await #54555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Aug 21, 2025
Merged

[stable31] fix(files_sharing): sharing status action permission and sidebar await #54555

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb53d1a
fix(files_sharing): sharing status action permission and sidebar await
skjnldsv Aug 14, 2025
7f59f39
fix(files_sharing): bypass sidebar call and return null straight away
skjnldsv Aug 21, 2025
b0c1c23
chore(assets): Recompile assets
nextcloud-command Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files_sharing): sharing status action permission and sidebar await 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
  • Loading branch information
@skjnldsv @backportbot
skjnldsv authored and backportbot[bot] committed Aug 21, 2025
commit eb53d1a7006754ee298c5998e194536ce666bbd1
8 changes: 8 additions & 0 deletions apps/files_sharing/src/files_actions/sharingStatusAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { action as sidebarAction } from '../../../files/src/actions/sidebarActio
import { generateAvatarSvg } from '../utils/AccountIcon'

import './sharingStatusAction.scss'
import { showError } from '@nextcloud/dialogs'

const isExternal = (node: Node) => {
return node.attributes?.['is-federated'] ?? false
Expand Down Expand Up @@ -125,7 +126,10 @@ export const action = new FileAction({
return true
}

// You need share permissions to share this file
// and read permissions to see the sidebar
return (node.permissions & Permission.SHARE) !== 0
&& (node.permissions & Permission.READ) !== 0
},

async exec(node: Node, view: View, dir: string) {
Expand All @@ -134,6 +138,10 @@ export const action = new FileAction({
window.OCA?.Files?.Sidebar?.setActiveTab?.('sharing')
return sidebarAction.exec(node, view, dir)
}

// Should not happen as the enabled check should prevent this
// leaving it here for safety or in case someone calls this action directly
showError(t('files_sharing', 'You do not have enough permissions to share this file.'))
return null
},

Expand Down