Skip to content

[stable31] fix(sharing): fix json decoding the list of groups excluded from sharing #54596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Aug 24, 2025
Merged

[stable31] fix(sharing): fix json decoding the list of groups excluded from sharing #54596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(sharing): fix json decoding the list of groups excluded from sharing 
json_decode() returns stdclass by default instead of an associative object, which can't be used for
array_diff or array_intersect later

Signed-off-by: Thomas Citharel <[email protected]>
  • Loading branch information
@tcitworld @backportbot
tcitworld authored and backportbot[bot] committed Aug 24, 2025
commit bfd0458e86b4b39eddf78e7c211689b6cb12bd23
2 changes: 1 addition & 1 deletion lib/private/Share20/ShareDisableChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function sharingDisabledForUser(?string $userId) {

if ($excludeGroups && $excludeGroups !== 'no') {
$groupsList = $this->config->getAppValue('core', 'shareapi_exclude_groups_list', '');
$excludedGroups = json_decode($groupsList);
$excludedGroups = json_decode($groupsList, true);
if (is_null($excludedGroups)) {
$excludedGroups = explode(',', $groupsList);
$newValue = json_encode($excludedGroups);
Expand Down
Loading