fix(theming): add missing color-text-success variable
#54624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was planned to be added and already documented. The use case is some rare occurences where we use success like text. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
nfebe and
skjnldsv
and removed request for
a team
susnux
commented
Aug 25, 2025
Comment on lines
-70
to
-71
| '--color-text-light' => $colorMainText, | ||
| '--color-text-lighter' => $colorMainText, |
Contributor
Author
There was a problem hiding this comment.
BTW those are removed as they are covered by the default theme which is inherited and replaced with other variables.
skjnldsv
approved these changes
Aug 25, 2025
CarlSchwan
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was planned to be added and already documented. The use case is some rare occurrences where we use success like text.
Checklist