feat: add proper element colors and adjust setup checks #54656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
design
jancborchardt
approved these changes
Aug 26, 2025
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
👀 damn this looks really nice, such an improvement to before!
susnux
requested review from
CarlSchwan and
artonge
and removed request for
nfebe and
sorbaugh
susnux
added
the
pending documentation
CarlSchwan
approved these changes
Aug 26, 2025
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
Tested locally and code looks good (but I'm far from a vue expert)
susnux
force-pushed
the
fix/color-variables
branch
from
e7a1b86 to
966d207
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/color-variables
branch
from
baf5fd0 to
f9030fc
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
susnux
removed
the
pending documentation
Contributor
Author
|
Documentation in nextcloud/documentation#13555 |
Merged
8 tasks
susnux
added a commit
that referenced
this pull request
Sep 8, 2025
* ref: #54656 Signed-off-by: Ferdinand Thiessen <[email protected]>
4 tasks
backportbot bot
pushed a commit
that referenced
this pull request
Sep 9, 2025
* ref: #54656 Signed-off-by: Ferdinand Thiessen <[email protected]>
AndyScherzinger
pushed a commit
that referenced
this pull request
Sep 9, 2025
* ref: #54656 Signed-off-by: Ferdinand Thiessen <[email protected]>
AndyScherzinger
pushed a commit
that referenced
this pull request
Sep 9, 2025
* ref: #54656 Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the issues happening after the secondary status color migration. By adding new variables one can support multiple Nextcloud versions just like:
color: var(--color-element-error, var(--color-error))which works on all versions.--color-element-error,--color-element-info,--color-element-success,--color-element-warningScreenshots
Checklist