Port away from IQueryBuilder::execute in lib/ and tests/ and fix invalid usage of UniqueConstraintViolationException #54664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
carl/port-away-execute-lib
branch
from
bd865ec to
496ffce
Compare
CarlSchwan
added
3. to review
CarlSchwan
force-pushed
the
carl/port-away-execute-lib
branch
from
496ffce to
23ea2d8
Compare
CarlSchwan
requested review from
a team,
ChristophWurst,
miaulalala,
nickvergessen and
st3iny
as code owners
CarlSchwan
requested review from
icewind1991,
leftybournes and
nfebe
and removed request for
a team
CarlSchwan
force-pushed
the
carl/port-away-execute-lib
branch
from
23ea2d8 to
36e4617
Compare
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Apart from the one new catch which I don't expect it looks good
added 4 commits
September 2, 2025 11:55
Replace by either executeStatement or executeQuery Signed-off-by: Carl Schwan <[email protected]>
UniqueConstraintViolationException is no longer throw directly but instead is now wrapped inside a \OCP\DB\Exception. So check the exception reason. Signed-off-by: Carl Schwan <[email protected]>
Replace by either executeStatement or executeQuery Signed-off-by: Carl Schwan <[email protected]>
These are nowadays also OCP\DB\Exception and if the id is not a numeric deleting by id is also non working. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/port-away-execute-lib
branch
from
36e4617 to
996be0f
Compare
nickvergessen
approved these changes
Sep 2, 2025
miaulalala
approved these changes
Sep 2, 2025
st3iny
approved these changes
Sep 2, 2025
Contributor
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Commits best reviewed separately
Checklist