Skip to content

[stable30] fix(files_versions): ensure IDs, Author and Label are strings #54768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solracsf merged 2 commits into from
Aug 30, 2025
Merged

[stable30] fix(files_versions): ensure IDs, Author and Label are strings #54768

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d50ef2
fix(files_versions): ensure author and label are string
solracsf Aug 30, 2025
9dd02d3
chore(assets): Recompile assets
nextcloud-command Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/files_versions/src/utils/versions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ export async function fetchVersions(fileInfo: any): Promise<Version[]> {
.filter(({ mime }) => mime !== '')
.map(version => formatVersion(version, fileInfo))

const authorIds = new Set(versions.map(version => version.author))
const authorIds = new Set(versions.map(version => String(version.author)))
const authors = await axios.post(generateUrl('/displaynames'), { users: [...authorIds] })

for (const version of versions) {
const author = authors.data.users[version.author]
const author = authors.data.users[version.author ?? '']
if (author) {
version.authorName = author
}
Expand Down Expand Up @@ -105,8 +105,8 @@ function formatVersion(version: any, fileInfo: any): Version {
return {
fileId: fileInfo.id,
// If version-label is defined make sure it is a string (prevent issue if the label is a number an PHP returns a number then)
label: version.props['version-label'] && String(version.props['version-label']),
author: version.props['version-author'] ?? null,
label: version.props['version-label'] ? String(version.props['version-label']) : '',
author: version.props['version-author'] ? String(version.props['version-author']) : null,
authorName: null,
filename: version.filename,
basename: moment(mtime).format('LLL'),
Expand Down
Loading