enh(avatars): use different colors for guests for the same name #54798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
requested review from
Altahrim,
nfebe and
provokateurin
and removed request for
a team
provokateurin
approved these changes
Sep 2, 2025
Make it harder to impersonate users who have not set their avatar. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/different-color-for-guest-with-same-name
branch
from
c8d1728 to
78022f5
Compare
jancborchardt
approved these changes
Sep 2, 2025
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Adding "(guest)" definitely makes sense, we do that in Talk as well. And adjusting the color generation according to that as well! :)
AndyScherzinger
approved these changes
Sep 2, 2025
max-nextcloud
deleted the
enh/different-color-for-guest-with-same-name
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it harder to impersonate users who have not set their avatar.
I'd like to use the generic guest name dialog that comes with Nextcloud 32 - but currently colors are the same for guests and authenticated users with the same name.
Screenshots (using avatar colors in text)