Fix(previews): prevent infinite loop in case of bad video file #54918
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @Vislike (thanks!), prevent infinite looping if a video file is provided with invalid/improper atom data.
Also, fixed a calculation to ensure the
moov atomis entirely contained within the downloaded data before skipping (previously only checked for the location of the beginning of themoov atom)feat(previews): previews for large remote files without full file download #53952