Skip to content

Fix response header check #5492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vbrandl wants to merge 2 commits into from
Closed

Fix response header check #5492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9487e5
Fix response header check
vbrandl Jun 20, 2017
207f9cd
Fix comparison
vbrandl Jun 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix comparison 
Forgot the `-` sign
  • Loading branch information
@vbrandl
vbrandl committed Jun 20, 2017
commit 207f9cd1ee3ea2a12fec53d3d59f72cdbd731c9f
2 changes: 1 addition & 1 deletion core/js/setupchecks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@
};

for (var header in securityHeaders) {
if(!xhr.getResponseHeader(header) || xhr.getResponseHeader(header).toLowerCase().indexOf(securityHeaders[header].toLowerCase()) === 1) {
if(!xhr.getResponseHeader(header) || xhr.getResponseHeader(header).toLowerCase().indexOf(securityHeaders[header].toLowerCase()) === -1) {
messages.push({
msg: t('core', 'The "{header}" HTTP header is not configured to equal to "{expected}". This is a potential security or privacy risk and we recommend adjusting this setting.', {header: header, expected: securityHeaders[header]}),
type: OC.SetupChecks.MESSAGE_TYPE_WARNING
Expand Down