Skip to content

Conversation

@provokateurin
Copy link
Member

Broken since #48224.
Checking if the source path is in the cache always returns false, because the file was already moved to a different path.
So any file that was trashed, did not update the parent folder sizes.

@provokateurin provokateurin added this to the Nextcloud 33 milestone Sep 8, 2025
@provokateurin provokateurin requested a review from a team as a code owner September 8, 2025 12:51
@provokateurin provokateurin requested review from nfebe and salmart-dev and removed request for a team September 8, 2025 12:51
@provokateurin provokateurin added the 3. to review Waiting for reviews label Sep 8, 2025
@provokateurin
Copy link
Member Author

/backport to stable32

@provokateurin
Copy link
Member Author

/backport to stable31

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
Any chance we can add a test to catch the issue next time?

@icewind1991
Copy link
Member

Could you add some tests for this, With the object store cache behavior being different it would be good to ensure that both behaviors are tested.

@provokateurin

This comment was marked as outdated.

@provokateurin provokateurin force-pushed the fix/files_trashbin/size-propagation branch from 200ef46 to b36af65 Compare September 9, 2025 11:39
@provokateurin
Copy link
Member Author

Added a test and also confirmed that this was only broken for S3 before and now it works for local and S3 storage.

@provokateurin provokateurin merged commit c0dc179 into master Sep 9, 2025
210 of 212 checks passed
@provokateurin provokateurin deleted the fix/files_trashbin/size-propagation branch September 9, 2025 13:36
@AndyScherzinger
Copy link
Member

/backport to stable31

@backportbot
Copy link

backportbot bot commented Sep 10, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/54950/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b36af651

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/54950/stable31

Error: Failed to push branch backport/54950/stable31: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member Author

/backport to stable31

@juliusknorr
Copy link
Member

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants