-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(files_trashbin): Fix size propagation when moving file to trash #54950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable32 |
|
/backport to stable31 |
come-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Any chance we can add a test to catch the issue next time?
|
Could you add some tests for this, With the object store cache behavior being different it would be good to ensure that both behaviors are tested. |
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: provokateurin <[email protected]>
200ef46 to
b36af65
Compare
|
Added a test and also confirmed that this was only broken for S3 before and now it works for local and S3 storage. |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/54950/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b36af651
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/54950/stable31Error: Failed to push branch backport/54950/stable31: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable31 |
|
/backport to stable30 |
Broken since #48224.
Checking if the source path is in the cache always returns false, because the file was already moved to a different path.
So any file that was trashed, did not update the parent folder sizes.