Skip to content

fix(files_sharing): use user defined passwords #55026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hamza221 wants to merge 2 commits into from
Closed

fix(files_sharing): use user defined passwords #55026

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4b7d65
fix(files_sharing): use user defined passwords
Darianisak Aug 13, 2025
b669932
chore(assets): Recompile assets
nextcloud-command Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files_sharing): use user defined passwords 
A previous MR(54055) resulted in the NcActionInput component responsible
for creating file shares discarding user provided passwords, in favor of
the system generated one.

This was caused by drift between the component and the underlying Share
model, resulting in the component calling .sync on a non-existent
attribute, which meant the password was never updated.

To reproduce (with password_policy enabled):
* Under a files "External Shares", click "Create public link"
* Supply a password to the password field, e.g., "testing-password_123"
* Click "Create share"
* Attempt to navigate to the generated share link and access the shared
  file with the password you provided at the time of creating the share.
* The provided password will be rejected, as it was never updated from
  the system generated one.

Signed-off-by: Darian Culver <[email protected]>
  • Loading branch information
@Darianisak @hamza221
Darianisak authored and hamza221 committed Sep 11, 2025
commit e4b7d65b1c8876928f6ef7f985ab5cb1d77101c2
2 changes: 1 addition & 1 deletion apps/files_sharing/src/components/SharingEntryLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
<NcActionInput v-if="pendingEnforcedPassword || isPasswordProtected"
class="share-link-password"
:label="t('files_sharing', 'Enter a password')"
:value.sync="share.newPassword"
:value.sync="share.password"
:disabled="saving"
:required="config.enableLinkPasswordByDefault || config.enforcePasswordForPublicLink"
:minlength="isPasswordPolicyEnabled && config.passwordPolicy.minLength"
Expand Down
Loading