fix: Dispatch favorite event with an actual path #55122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
Altahrim,
nfebe and
provokateurin
and removed request for
a team
artonge
added
bug
3. to review
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
artonge
force-pushed
the
artonge/fix/favorite_activity
branch
from
07ac029 to
38c12ac
Compare
provokateurin
requested changes
Sep 15, 2025
artonge
force-pushed
the
artonge/fix/favorite_activity
branch
from
38c12ac to
cef7455
Compare
artonge
force-pushed
the
artonge/fix/favorite_activity
branch
from
cef7455 to
90b8662
Compare
provokateurin
approved these changes
Sep 15, 2025
artonge
force-pushed
the
artonge/fix/favorite_activity
branch
3 times, most recently
from
b388bc4 to
c835bd1
Compare
The `$path` argument was added in #48612, but was never actually used by the callers. The path was therefore missing in the favorite/unfavorite events, which lead to a broken activity information. I also added a fallback to handle `addToFavorites` and `removeFromFavorites`, which are part of a public API, and are calling `tagAs` and `untag` without `$path`. Fix nextcloud/activity#2134 Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/favorite_activity
branch
from
c835bd1 to
634e8d2
Compare
icewind1991
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$pathargument was added in #48612, but was never actually used by the callers. The path was therefore missing in the favorite/unfavorite events, which lead to a broken activity information.I also added a fallback to handle
addToFavoritesandremoveFromFavorites, which are part of a public API, and are callingtagAsanduntagwithout$path.Fix nextcloud/activity#2134