fix(sharing): Allow reasonable control for 'Hide download' on fed shares #55251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
come-nc,
icewind1991 and
salmart-dev
and removed request for
a team
nfebe
force-pushed
the
fix/federated-share-hide-download
branch
from
a32def2 to
6c9b2e3
Compare
Member
|
Thank you for working on this! I think it would be good if the possibilities were also somehow visible in the UI. Is this the case with this already? |
come-nc
approved these changes
Sep 22, 2025
Contributor
Author
This changes should solve the issue of the toggle not taking effect in the UI. |
artonge
reviewed
Sep 24, 2025
artonge
changed the title
nfebe
force-pushed
the
fix/federated-share-hide-download
branch
from
5c51164 to
8ed4c1a
Compare
artonge
reviewed
Oct 9, 2025
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Let's have some tests to prevent any regressions
|
@nfebe is there any chance this pr can be merged soon? |
nfebe
force-pushed
the
fix/federated-share-hide-download
branch
3 times, most recently
from
b50837d to
14298fe
Compare
Contributor
Author
Updated it and added some tests. (Sorry I have had some laptop downtime recently) |
nfebe
force-pushed
the
fix/federated-share-hide-download
branch
from
14298fe to
02de83d
Compare
artonge
approved these changes
Oct 21, 2025
nfebe
force-pushed
the
fix/federated-share-hide-download
branch
from
02de83d to
32f92af
Compare
nfebe
force-pushed
the
fix/federated-share-hide-download
branch
from
32f92af to
712b0a3
Compare
|
@nfebe What is needed to merge this PR? |
When creating public links from federated shares, users should be able to set the 'Hide download' option independently as long as they are more restrictive than the original share permissions. Previously, the `checkInheritedAttributes` method was ignoring user preferences and always overriding the hideDownload setting based solely on inherited permissions, preventing users from disabling downloads even when the parent share allowed them. This fix implements some sort of inheritance logic: - Users can only be MORE restrictive than parent shares, never LESS restrictive - If parent hides downloads -> child MUST hide downloads (enforced) - If parent allows downloads -> child can CHOOSE to hide or allow downloads - If parent forbids downloads entirely -> child cannot enable downloads Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/federated-share-hide-download
branch
from
712b0a3 to
6401689
Compare
|
Thank you! 🎉 |
|
@nfebe any chances to see that backported in 32 or not at all ? |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating public links from federated shares, users should be able to set the 'Hide download' option independently as long as they are more restrictive than the original share permissions.
Previously, the
checkInheritedAttributesmethod was ignoring user preferences and always overriding the hideDownload setting based solely on inherited permissions, preventing users from disabling downloads even when the parent share allowed them.This fix implements some sort of inheritance logic: