Skip to content

fix(comments): explicitly return limbo status of comment #55275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edward-ly merged 2 commits into from
Sep 24, 2025
Merged

fix(comments): explicitly return limbo status of comment #55275

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8858ba1
fix(comments): explicitly return limbo status of comment
edward-ly Sep 24, 2025
6f7b3b3
chore(assets): Recompile assets
nextcloud-command Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(comments): explicitly return limbo status of comment 
Otherwise, the `checkForId` function returns `undefined` regardless of
whether the comment is in limbo or not.

Signed-off-by: Edward Ly <[email protected]>
  • Loading branch information
@edward-ly
edward-ly committed Sep 24, 2025
commit 8858ba12cdca10525d37a89077abfb0a6af8da67
2 changes: 1 addition & 1 deletion apps/comments/src/store/deletedCommentLimbo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const useDeletedCommentLimbo = defineStore('deletedCommentLimbo', {
},

checkForId(id) {
this.idsInLimbo.includes(id)
return this.idsInLimbo.includes(id)
},
},
})
Loading